From 36d797b391bebc553e0ce33b92211b8f958c234c Mon Sep 17 00:00:00 2001
From: Yury <rip95_95@mail.ru>
Date: Tue, 25 Mar 2025 18:51:55 +0200
Subject: [PATCH] Fix item sell formula for Ammo and Ability items

---
 .../Services/CloudScript/Functions/SellItemClient.cs     | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/Prospect.Server.Api/Services/CloudScript/Functions/SellItemClient.cs b/src/Prospect.Server.Api/Services/CloudScript/Functions/SellItemClient.cs
index 82cb674..da795a8 100644
--- a/src/Prospect.Server.Api/Services/CloudScript/Functions/SellItemClient.cs
+++ b/src/Prospect.Server.Api/Services/CloudScript/Functions/SellItemClient.cs
@@ -117,11 +117,11 @@ public class SellItemsClientFunction : ICloudScriptFunction<SellItemsClientReque
                 continue;
             }
             var blueprintData = blueprints[inventoryItem.BaseItemId];
-            // TODO: Probably better to decide based on item kind instead
-            if (inventoryItem.Durability == -1) {
+            // NOTE: Ammo and consumables have reverse price mapping.
+            if (blueprintData.Kind == "Ammo" || blueprintData.Kind == "Ability") {
                 factionProgression += (int)((float)blueprintData.OverrideScrappingReputation / blueprintData.MaxAmountPerStack * inventoryItem.Amount);
                 balance.SoftCurrency += (int)((float)blueprintData.OverrideScrappingReturns / blueprintData.MaxAmountPerStack * inventoryItem.Amount);
-            } else {
+            } else if (blueprintData.Kind == "Armor") {
                 factionProgression += (int)Math.Max(
                     (float)inventoryItem.Durability / blueprintData.DurabilityMax * blueprintData.OverrideScrappingReputation,
                     blueprintData.OverrideScrappingReputation * blueprintData.DurabilityBrokenScrappingReturnModifier
@@ -130,6 +130,9 @@ public class SellItemsClientFunction : ICloudScriptFunction<SellItemsClientReque
                     (float)inventoryItem.Durability / blueprintData.DurabilityMax * blueprintData.OverrideScrappingReturns,
                     blueprintData.OverrideScrappingReturns * blueprintData.DurabilityBrokenScrappingReturnModifier
                 );
+            } else {
+                factionProgression += blueprintData.OverrideScrappingReputation  * inventoryItem.Amount;
+                balance.SoftCurrency += blueprintData.OverrideScrappingReturns * inventoryItem.Amount;
             }
 
             scrappedItemIds.Add(itemId);